[subexp-daq] NURDLIB - SIS3316 - major rework of check_hit

[Hans Toshihide Törnqvist]

Dear Günter,

I had a look, it seemed fine.

There is a rebased version against the current main:
SIS3316_check_hit_reworked_rebased

Due to some new safety checks, I had to remove a sis3316-only config 
function and instead rely on common existing config functions, so please 
try it out and see that it works ok. If this runs I will put all of it 
in 'main'!

Best regards,
Hans


On 2024-06-10 18:54, Weber, Guenter Dr. wrote:
> Dear all,
> 
> 
> I just pushed a new version of the sis3316.c, where check_hit was 
> rewritten. The reason was that the existing code did not work together 
> with the discard option for the channel readout. Please note that in 
> readout_dma I am now using an excess bit (not necessary to represent 
> even the largest number of raw sample words possible) to store the 
> information that an event was discarded. This is then used in check_event.
> 
> 
> As I did a lot of changes, please have an extra close look at the code.
> 
> 
> If everyone is happy with the new check_event, I will also make changes 
> to the discard routine in readout_dma as at the moment, some assumptions 
> on the settings of the module are hard coded - at least that is my 
> impression at the moment.
> 
> 
> 
> 
> Thanks a lot!
> 
> 
> 
> 
> Best greetings
> 
> Günter
> 
> 
>