[subexp-daq] New warning meassage in R3BFUSER

[Håkan T Johansson]

I actually do not see that warning myself, even if nurlib during 
compilation says

FUNC_NONNULL:YES

Anyhow, I suspect that if you change in

include/nurdlib/crate.h

in the prototype of crate_dt_release_set_func to have

FUNC_NONNULL((1,2))  instead of  FUNC_NONNULL(())

then it might work.

No doubt Hans will then make a more permanent fix...  ;)

Cheers,
Håkan



On Mon, 15 Jul 2024, Weber, Guenter Dr. wrote:

> 
> Dear Håkan,
> 
> 
> thank you for the reply.
> 
> 
> After implementing the suggested changes, I now get the following warning
> (on PC):
> 
> 
> (base) mbsdaq at atpnbg011:~/mbsrun/rio4/2024_mcalstruck/r3bfuser$ make
> fuser_drasi
> NCONF build_cc_x86_64-linux-gnu_7_debug/nconf.args
> For nconf results and logs, see also
> build_cc_x86_64-linux-gnu_7_debug/nconf*.
> UDP:ARPA_INET_H
> build_cc_x86_64-linux-gnu_7_debug/nconf.args done.
> CC    build_cc_x86_64-linux-gnu_7_debug/subevent.drasi.o
> CC    build_cc_x86_64-linux-gnu_7_debug/f_user.drasi.o
> f_user.c: In function ‘f_user_init’:
> f_user.c:697:2: warning: null argument where non-null required (argument 3)
> [-Wnonnull]
>   crate_dt_release_set_func(g_crate, dt_release, NULL);
>   ^~~~~~~~~~~~~~~~~~~~~~~~~
> CC    build_cc_x86_64-linux-gnu_7_debug/udp.drasi.o
> LD    build_cc_x86_64-linux-gnu_7_debug/m_read_meb.drasi
> build_cc_x86_64-linux-gnu_7_debug: Simon says: Alles wird gut ;o)
> 
> On the RIO4 there is no warning:
> 
> 
> RIO4-MCAL-1 mbsdaq > make fuser_drasi
> NCONF build_cc_ppc-linux_4.2.2_debug/nconf.args
> For nconf results and logs, see also build_cc_ppc-linux_4.2.2_debug/nconf*.
> UDP:ARPA_INET_H
> build_cc_ppc-linux_4.2.2_debug/nconf.args done.
> CC    build_cc_ppc-linux_4.2.2_debug/f_user.drasi.o
> CC    build_cc_ppc-linux_4.2.2_debug/subevent.drasi.o
> CC    build_cc_ppc-linux_4.2.2_debug/udp.drasi.o
> LD    build_cc_ppc-linux_4.2.2_debug/m_read_meb.drasi
> build_cc_ppc-linux_4.2.2_debug: Simon says: Alles wird gut ;o)
> 
> In a few minutes I can tell you if the DAQ is running with the new software
> or not.
> 
> 
> 
> 
> 
> Best greetings
> 
> Günter
> 
> 
> 
> 
> 
> ____________________________________________________________________________
> Von: subexp-daq <subexp-daq-bounces at lists.chalmers.se> im Auftrag von Håkan
> T Johansson <f96hajo at chalmers.se>
> Gesendet: Montag, 15. Juli 2024 15:49:23
> An: Discuss use of Nurdlib, TRLO II, drasi and UCESB.
> Betreff: Re: [subexp-daq] New warning meassage in R3BFUSER  
> 
> Dear Günter,
> 
> it looks like with a change of the second parameter of log_callback (both
> in prototype an definition) of r3bfuser/f_user.c from unsigned to int,
> then in compiles.
> 
> Likely caused by commit '36772113' in nurdlib that changed line numbers
> from unsigned to int.
> 
> Cheers,
> Håkan
> 
> 
> 
> On Mon, 15 Jul 2024, Weber, Guenter Dr. wrote:
> 
> >
> > Dear all,
> >
> >
> > I just set up a new DAQ system (new NURDLIB, TRLOII, DRASI, R3BFUSER,
> etc.).
> >
> >
> > I followed the 'cooking receipt' that I git from Hakan, as always.
> >
> >
> > When compiling fuser_drasi, the following happens (on PC):
> >
> >
> > (base) mbsdaq at atpnbg011:~/mbsrun/rio4/2024_mcalstruck/r3bfuser$ make
> > fuser_drasi
> > NCONF build_cc_x86_64-linux-gnu_7_debug/nconf.args
> > For nconf results and logs, see also
> > build_cc_x86_64-linux-gnu_7_debug/nconf*.
> > UDP:ARPA_INET_H
> > build_cc_x86_64-linux-gnu_7_debug/nconf.args done.
> > CC    build_cc_x86_64-linux-gnu_7_debug/subevent.drasi.o
> > CC    build_cc_x86_64-linux-gnu_7_debug/f_user.drasi.o
> > f_user.c: In function ‘f_user_init’:
> > f_user.c:682:26: warning: passing argument 1 of ‘nurdlib_setup’ from
> > incompatible pointer type [-Wincompatible-pointer-types]
> >   g_crate = nurdlib_setup(log_callback, path);
> >                           ^~~~~~~~~~~~
> > In file included from f_user.c:15:0:
> > ../nurdlib/include/nurdlib.h:28:15: note: expected ‘LogCallback {aka void
> > (*)(const char *, int,  unsigned int,  const char *)}’ but argument is of
> > type ‘void (*)(const char *, unsigned int,  unsigned int,  const char *)’
> >  struct Crate *nurdlib_setup(LogCallback, char const *) FUNC_RETURNS;
> >                ^~~~~~~~~~~~~
> > f_user.c:697:2: warning: null argument where non-null required (argument
> 3)
> > [-Wnonnull]
> >   crate_dt_release_set_func(g_crate, dt_release, NULL);
> >   ^~~~~~~~~~~~~~~~~~~~~~~~~
> > CC    build_cc_x86_64-linux-gnu_7_debug/udp.drasi.o
> > LD    build_cc_x86_64-linux-gnu_7_debug/m_read_meb.drasi
> > build_cc_x86_64-linux-gnu_7_debug: Simon says: Alles wird gut ;o)
> >
> >
> > On the RIO4 the warning is a bit less detailed:
> >
> >
> > RIO4-MCAL-1 mbsdaq > make fuser_drasi
> > NCONF build_cc_ppc-linux_4.2.2_debug/nconf.args
> > For nconf results and logs, see also
> build_cc_ppc-linux_4.2.2_debug/nconf*.
> > UDP:ARPA_INET_H
> > build_cc_ppc-linux_4.2.2_debug/nconf.args done.
> > CC    build_cc_ppc-linux_4.2.2_debug/f_user.drasi.o
> > f_user.c: In function 'f_user_init':
> > f_user.c:682: warning: passing argument 1 of 'nurdlib_setup' from
> > incompatible pointer type
> > CC    build_cc_ppc-linux_4.2.2_debug/subevent.drasi.o
> > CC    build_cc_ppc-linux_4.2.2_debug/udp.drasi.o
> > LD    build_cc_ppc-linux_4.2.2_debug/m_read_meb.drasi
> > build_cc_ppc-linux_4.2.2_debug: Simon says: Alles wird gut ;o)
> >
> > Any ideas what might have happened here? Or is this normal behaviour?
> >
> >
> >
> > Many thanks!
> >
> >
> >
> >
> >
> > Best greetings
> >
> > Günter
> >
> >
> >
> >
> >
> >
> >
> 
>